Getting an API-key when provided only username and password #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Talento90
previously approved these changes
Jan 27, 2021
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "displayName": "GlueHome Homebridge Plugin", | |||
| "name": "@gluehome/homebridge-gluehome", | |||
| "version": "0.1.3", | |||
| "version": "0.1.4", | |||
src/api/client.ts
Outdated
| @@ -1,6 +1,19 @@ | |||
| import axios, { AxiosInstance } from "axios" | |||
| import { Lock, LockOperation, CreateLockOperation } from "./" | |||
|
|
|||
|
|
|||
| export async function issueApiKey(username: string, password: string): Promise<string> { | |||
| let response = await axios.post("https://user-api.gluehome.com/v1/api-keys", { | |||
There was a problem hiding this comment.
Can we add the api Url as constant?
const API_URL = 'https://user-api.gluehome.com';
let response = await axios.post(`{API_URL}/v1/api-keys`...
kafouros
force-pushed
the
user-credentials
branch
from
c16d234
to
61adfb5
Compare
Add BasicAuth scheme alternative through configuration. Graceful handling of 503 (lock busy) errors. Increase polling frequency during a lock operation.
kafouros
force-pushed
the
user-credentials
branch
from
8683352
to
e85702e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.